App service support for MI #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Nov 28, 2024
bgavrilMS
reviewed
Nov 28, 2024
bgavrilMS
reviewed
Nov 28, 2024
bgavrilMS
reviewed
Nov 28, 2024
bgavrilMS
reviewed
Nov 28, 2024
chlowell
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Blockers are:
- query parameter names (docs)
- returned token expiration time is always 0
- fake token responses in tests don't resemble actual responses
Expiration time is always 0 because App Service responses include only expires_on (docs) and MSAL unmarshals only expires_in, using a custom UnmarshalJSON to convert that duration to an instant. Unit tests pass despite this because their fake responses always include expires_in
Updated the resource Id parameter for every source except IMDS
chlowell
reviewed
Dec 31, 2024
chlowell
reviewed
Jan 3, 2025
Added support for expires_in different time formats for expire_in support for principle_id for app service in managed identity
chlowell
reviewed
Jan 6, 2025
chlowell
reviewed
Jan 7, 2025
chlowell
reviewed
Jan 7, 2025
bgavrilMS
reviewed
Jan 7, 2025
chlowell
reviewed
Jan 15, 2025
Co-authored-by: Charles Lowell <[email protected]>
chlowell
reviewed
Jan 16, 2025
| payload: ` | ||
| { | ||
| "access_token": "secret", | ||
| "expires_on": "", |
There was a problem hiding this comment.
should also have a success case in which only expires_in is present
|
chlowell
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for App service
Added support for logging in Managed Identity